-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure traces are flushed in development when there is an error #29149
Merged
timneutkens
merged 1 commit into
vercel:canary
from
timneutkens:fix/dev-trace-flushing-warning
Sep 16, 2021
Merged
Ensure traces are flushed in development when there is an error #29149
timneutkens
merged 1 commit into
vercel:canary
from
timneutkens:fix/dev-trace-flushing-warning
Sep 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
huozhi,
ijjk,
padmaia,
shuding and
styfle
as code owners
September 16, 2021 16:59
timneutkens
commented
Sep 16, 2021
return | ||
} | ||
|
||
if (state.warnings) { | ||
Log.warn(state.warnings.join('\n\n')) | ||
if (state.appUrl) { | ||
Log.info(`ready on ${state.appUrl}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an accidental leftover that I just noticed so I've removed it 👍
ijjk
approved these changes
Sep 16, 2021
styfle
approved these changes
Sep 16, 2021
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
buildDuration | 16.5s | 16.4s | -103ms |
buildDurationCached | 4.1s | 4s | -77ms |
nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.623 | 3.506 | -0.12 |
/ avg req/sec | 690.08 | 713 | +22.92 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.937 | 1.954 | |
/error-in-render avg req/sec | 1290.63 | 1279.52 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 26.7 kB | 26.7 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 70.6 kB | 70.6 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
index.html gzip | 540 B | 540 B | ✓ |
link.html gzip | 552 B | 552 B | ✓ |
withRouter.html gzip | 535 B | 535 B | ✓ |
Overall change | 1.63 kB | 1.63 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
buildDuration | 8.2s | 8s | -217ms |
buildDurationCached | 4.1s | 3.9s | -236ms |
nodeModulesSize | 182 MB | 182 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.42 | 3.438 | |
/ avg req/sec | 731.09 | 727.11 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.901 | 1.872 | -0.03 |
/error-in-render avg req/sec | 1315.38 | 1335.46 | +20.08 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
264.HASH.js gzip | 179 B | 179 B | ✓ |
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework-HASH.js gzip | 50.7 kB | 50.7 kB | ✓ |
main-HASH.js gzip | 34.6 kB | 34.6 kB | ✓ |
webpack-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
Overall change | 101 kB | 101 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.32 kB | 1.32 kB | ✓ |
_error-HASH.js gzip | 179 B | 179 B | ✓ |
amp-HASH.js gzip | 315 B | 315 B | ✓ |
css-HASH.js gzip | 330 B | 330 B | ✓ |
dynamic-HASH.js gzip | 2.8 kB | 2.8 kB | ✓ |
head-HASH.js gzip | 356 B | 356 B | ✓ |
hooks-HASH.js gzip | 638 B | 638 B | ✓ |
image-HASH.js gzip | 575 B | 575 B | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.2 kB | 2.2 kB | ✓ |
routerDirect..HASH.js gzip | 327 B | 327 B | ✓ |
script-HASH.js gzip | 392 B | 392 B | ✓ |
withRouter-HASH.js gzip | 323 B | 323 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
_buildManifest.js gzip | 512 B | 512 B | ✓ |
Overall change | 512 B | 512 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/dev-trace-flushing-warning | Change | |
---|---|---|---|
index.html gzip | 538 B | 538 B | ✓ |
link.html gzip | 550 B | 550 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Failing test suitesCommit: 346d820 test/development/acceptance/ReactRefreshLogBoxMisc.test.ts
Expand output● ReactRefreshLogBox › server-side only compilation errors
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples