Add next-multilingual example
#29386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbouvrette
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
|
Hi @leerob, is there anything missing to merge this PR? This is my first PR so I wanted to make sure! |
|
@leerob @timneutkens is it possible to take a quick look at this PR? It's been open for a while and it would help us to get more visibility on our open-source package build solely for Next.js :) |
leerob
reviewed
Jan 19, 2022
leerob
reviewed
Jan 19, 2022
Reverting commit
leerob
reviewed
Jan 19, 2022
leerob
reviewed
Jan 19, 2022
leerob
previously approved these changes
Jan 19, 2022
|
@leerob sorry to bother you again about this - I saw the build was complaining about a prettier issue because of the missing blank line at the end of the readme. |
leerob
approved these changes
Jan 23, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes Co-authored-by: Lee Robinson <9113740+leerob@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples