Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify locale properties on context object in data-fetching #29566

Merged
merged 6 commits into from
Oct 4, 2021

Conversation

TyMick
Copy link
Contributor

@TyMick TyMick commented Oct 2, 2021

Until I started looking into the source code to verify, I thought that locale, locales, and defaultLocale were being parsed from the Accept-Language header somehow. This'll help other people like me who are reading the Data Fetching page but weren't already aware of Next.js's Internationalized Routing features.

Documentation / Examples

  • Make sure the linting passes

Until I started looking into the source code to verify, I thought that
`locale`, `locales`, and `defaultLocale` were being parsed from the
[`Accept-Language`][1] header somehow.

[1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language
@kodiakhq kodiakhq bot merged commit c06a3c1 into vercel:canary Oct 4, 2021
@TyMick
Copy link
Contributor Author

TyMick commented Oct 5, 2021

🚀 Thanks for the revisions!

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants