reduce default maxInactiveAge to 15s #29817

sokra · 2021-10-11T14:25:10Z

With persistent caching and other disposing fixes we can safely reduce the time before pages are disposed.

The last 2 client pages are still never disposed.

ijjk · 2021-10-11T14:49:06Z

Failing test suites

Commit: 577a709

test/development/basic/hmr.test.ts

basic HMR > Error Recovery > should detect runtime errors on the module scope
basic HMR > Error Recovery > should recover from errors in the render function
basic HMR > Error Recovery > should recover after exporting an invalid page
basic HMR > Error Recovery > should recover after a bad return from the render function
basic HMR > Error Recovery > should recover after undefined exported as default
basic HMR > Error Recovery > should recover after an error reported via SSR

Expand output

● basic HMR › Error Recovery › should detect runtime errors on the module scope

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:425:9)

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:455:9)

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:510:9)

● basic HMR › Error Recovery › should recover after exporting an invalid page

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after exporting an invalid page 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about5"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  488 |
  489 |         expect(await hasRedbox(browser)).toBe(true)
> 490 |         expect(await getRedboxHeader(browser)).toMatchInlineSnapshot(`
      |                                                ^
  491 |           " 1 of 1 unhandled error
  492 |           Server Error
  493 |

  at Object.<anonymous> (development/basic/hmr.test.ts:490:48)

● basic HMR › Error Recovery › should recover after a bad return from the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:558:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:614:8)

● basic HMR › Error Recovery › should recover after an error reported via SSR

TIMED OUT: /Hello/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:489:17)

ijjk · 2021-10-11T16:47:38Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
buildDuration	13.9s	13.8s	-105ms
buildDurationCached	3.2s	3.3s	⚠️ +127ms
nodeModulesSize	195 MB	195 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.329	3.285	-0.04
/ avg req/sec	751	761.05	+10.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.839	1.771	-0.07
/error-in-render avg req/sec	1359.78	1411.25	+51.47

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.9 kB	26.9 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.8 kB	70.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.12 kB	4.12 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.9 kB	12.9 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
_buildManifest.js gzip	494 B	494 B	✓
Overall change	494 B	494 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Decrease detected ✓)

General

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
buildDuration	7s	6.8s	-243ms
buildDurationCached	3.1s	3.2s	⚠️ +68ms
nodeModulesSize	195 MB	195 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.272	3.285	⚠️ +0.01
/ avg req/sec	764.05	760.98	⚠️ -3.07
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.698	1.729	⚠️ +0.03
/error-in-render avg req/sec	1472.45	1445.55	⚠️ -26.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	35 kB	35 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	355 B	355 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	555 B	555 B	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.22 kB	2.22 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
_buildManifest.js gzip	511 B	511 B	✓
Overall change	511 B	511 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js default/faster-disposing	Change
index.html gzip	538 B	538 B	✓
link.html gzip	553 B	553 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 7d1f123

reduce default maxInactiveAge to 15s

577a709

sokra requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners October 11, 2021 14:25

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 11, 2021

timneutkens approved these changes Oct 11, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'canary' into default/faster-disposing

c5191c0

This comment has been minimized.

Sign in to view

Merge branch 'canary' into default/faster-disposing

7d1f123

kodiakhq bot merged commit 41abf8b into canary Oct 11, 2021

kodiakhq bot deleted the default/faster-disposing branch October 11, 2021 17:12

styfle added the hacktoberfest-accepted label Oct 15, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reduce default maxInactiveAge to 15s #29817

reduce default maxInactiveAge to 15s #29817

sokra commented Oct 11, 2021

This comment has been minimized.

ijjk commented Oct 11, 2021

This comment has been minimized.

ijjk commented Oct 11, 2021

reduce default maxInactiveAge to 15s #29817

reduce default maxInactiveAge to 15s #29817

Conversation

sokra commented Oct 11, 2021

This comment has been minimized.

ijjk commented Oct 11, 2021

Failing test suites

This comment has been minimized.

ijjk commented Oct 11, 2021

Stats from current PR