-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config import on Windows and disable test in failing envs #29971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
buildDuration | 11.7s | 11.7s | -33ms |
buildDurationCached | 2.7s | 2.8s | |
nodeModulesSize | 199 MB | 199 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.775 | 2.613 | -0.16 |
/ avg req/sec | 900.88 | 956.72 | +55.84 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.207 | 1.186 | -0.02 |
/error-in-render avg req/sec | 2071.54 | 2107.66 | +36.12 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
558.HASH.js gzip | 3.02 kB | 3.02 kB | ✓ |
779.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 25 kB | 25 kB | ✓ |
webpack-HASH.js gzip | 1.49 kB | 1.49 kB | ✓ |
Overall change | 71.9 kB | 71.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
_app-HASH.js gzip | 977 B | 977 B | ✓ |
_error-HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
amp-HASH.js gzip | 553 B | 553 B | ✓ |
css-HASH.js gzip | 328 B | 328 B | ✓ |
dynamic-HASH.js gzip | 2.73 kB | 2.73 kB | ✓ |
head-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 5.86 kB | 5.86 kB | ✓ |
index-HASH.js gzip | 260 B | 260 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 320 B | 320 B | ✓ |
script-HASH.js gzip | 386 B | 386 B | ✓ |
withRouter-HASH.js gzip | 319 B | 319 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 19.9 kB | 19.9 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
_buildManifest.js gzip | 490 B | 490 B | ✓ |
Overall change | 490 B | 490 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
index.html gzip | 538 B | 538 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
buildDuration | 5.9s | 5.9s | -24ms |
buildDurationCached | 2.7s | 2.8s | |
nodeModulesSize | 199 MB | 199 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.726 | 2.792 | |
/ avg req/sec | 916.93 | 895.57 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.245 | 1.219 | -0.03 |
/error-in-render avg req/sec | 2008.14 | 2050.61 | +42.47 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
675-HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
770.HASH.js gzip | 178 B | 178 B | ✓ |
framework-HASH.js gzip | 50.8 kB | 50.8 kB | ✓ |
main-HASH.js gzip | 35.2 kB | 35.2 kB | ✓ |
webpack-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
Overall change | 102 kB | 102 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.33 kB | 1.33 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 315 B | 315 B | ✓ |
css-HASH.js gzip | 331 B | 331 B | ✓ |
dynamic-HASH.js gzip | 2.79 kB | 2.79 kB | ✓ |
head-HASH.js gzip | 355 B | 355 B | ✓ |
hooks-HASH.js gzip | 637 B | 637 B | ✓ |
image-HASH.js gzip | 555 B | 555 B | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 2.22 kB | 2.22 kB | ✓ |
routerDirect..HASH.js gzip | 326 B | 326 B | ✓ |
script-HASH.js gzip | 393 B | 393 B | ✓ |
withRouter-HASH.js gzip | 322 B | 322 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 10.1 kB | 10.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
_buildManifest.js gzip | 510 B | 510 B | ✓ |
Overall change | 510 B | 510 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | ijjk/next.js fix/azure | Change | |
---|---|---|---|
index.html gzip | 538 B | 538 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
ijjk
requested review from
huozhi,
padmaia,
shuding,
styfle and
timneutkens
as code owners
October 16, 2021 18:54
timneutkens
approved these changes
Oct 16, 2021
huozhi
approved these changes
Oct 16, 2021
styfle
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! 🎉
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29935 this fixes the failing tests on Azure as it seems the
import()
needs to be prefixed withfile://
on Windows or an error is thrown. It also disables the config unit tests since a dynamic import inside ofjest
on either an m1 on macOS or Windows using node 14 causes a segfault from being used inside ofvm
.segfault error in jest
Windows absolute import error