Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep sortedMiddleware intact as it's used by the runtime #30361

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 26, 2021

No description provided.

@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
buildDuration 18s 18.2s ⚠️ +162ms
buildDurationCached 3.7s 3.7s -7ms
nodeModulesSize 207 MB 207 MB ⚠️ +203 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
/ failed reqs 0 0
/ total time (seconds) 3.339 3 -0.34
/ avg req/sec 748.69 833.38 +84.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.593 1.409 -0.18
/error-in-render avg req/sec 1569.4 1774.38 +204.98
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
buildDuration 14.8s 14.6s -177ms
buildDurationCached 3.6s 3.7s ⚠️ +188ms
nodeModulesSize 207 MB 207 MB ⚠️ +203 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
/ failed reqs 0 0
/ total time (seconds) 2.99 2.897 -0.09
/ avg req/sec 836.14 863.04 +26.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.387 1.351 -0.04
/error-in-render avg req/sec 1802.43 1850.48 +48.05
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/keep-sorted-middleware Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: dee14d7

@huozhi huozhi merged commit 9560713 into canary Oct 26, 2021
@huozhi huozhi deleted the bugfix/keep-sorted-middleware branch October 26, 2021 20:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants