Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for importing unsupported native modules #30829

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 2, 2021

Improvement for #30696, covering more native module when failed on edge runtime

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 2, 2021
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review November 2, 2021 19:45
@ijjk
Copy link
Member

ijjk commented Nov 2, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
buildDuration 24.4s 23.9s -513ms
buildDurationCached 5.1s 5s -100ms
nodeModulesSize 293 MB 293 MB ⚠️ +1.17 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
/ failed reqs 0 0
/ total time (seconds) 4.197 3.94 -0.26
/ avg req/sec 595.64 634.49 +38.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.035 2.091 ⚠️ +0.06
/error-in-render avg req/sec 1228.21 1195.57 ⚠️ -32.64
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
buildDuration 25.7s 26.3s ⚠️ +596ms
buildDurationCached 5.1s 5s -129ms
nodeModulesSize 293 MB 293 MB ⚠️ +1.17 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
/ failed reqs 0 0
/ total time (seconds) 3.904 3.967 ⚠️ +0.06
/ avg req/sec 640.32 630.2 ⚠️ -10.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.029 2.036 ⚠️ +0.01
/error-in-render avg req/sec 1232.16 1228.07 ⚠️ -4.09
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js enhance/rsc-error-msg Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 2dc01bf

@kodiakhq kodiakhq bot merged commit ce1a170 into vercel:canary Nov 2, 2021
@huozhi huozhi deleted the enhance/rsc-error-msg branch November 2, 2021 21:42
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants