Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with cookies-next package #31243

Merged
merged 28 commits into from Jul 22, 2022

Conversation

andreizanik
Copy link
Contributor

Add example with cookies-next package

@ijjk ijjk added the examples Issue/PR related to examples label Nov 10, 2021
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you convert this to TypeScript to match our example guidelines? 🙏

Let me know if you need any help!

@andreizanik
Copy link
Contributor Author

Thanks, could you convert this to TypeScript to match our example guidelines? 🙏

Let me know if you need any help!

Done!

@andreizanik andreizanik requested review from balazsorban44 and removed request for lfades June 28, 2022 12:44
andreizanik and others added 2 commits June 29, 2022 14:17
balazsorban44
balazsorban44 previously approved these changes Jun 30, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kodiakhq bot and others added 3 commits June 30, 2022 10:07
@andreizanik
Copy link
Contributor Author

Thanks!

There was a problem with automatic checks due to the style code. I fixed it.
I also changed the function name to match the cookie container idiom (as of the latest release of the package).

Please check the pull request again

balazsorban44
balazsorban44 previously approved these changes Jul 6, 2022
@andreizanik
Copy link
Contributor Author

I get a new problem with auto check

Build, test, and deploy / lint (pull_request)

lerna notice cli v4.0.0
lerna info ci enabled
lerna ERR! EWORKSPACES Yarn workspaces need to be defined in the root package.json.
lerna ERR! EWORKSPACES See: https://github.com/lerna/lerna/blob/master/commands/bootstrap/README.md#--use-workspaces
 ELIFECYCLE  Command failed with exit code 1.
ERROR: "lint-typescript" exited with 1.
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

I followed the link and realized what I need to add "workspaces": ["packages/*"] to package.json
with this line i get no error locally

I also found that the prettier finds an error in the file/examples/cms-tina/.tina/__generated__/schema.gql

But this file has a comment

# DO NOT MODIFY THIS FILE. This file is automatically generated by Tina

After that I did not add any edits, because I do not know how to do it right. I think i need advice

@ijjk ijjk merged commit e8bbf14 into vercel:canary Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants