Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure wasm dev artifact uploads even on cache hit #32248

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 7, 2021

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Dec 7, 2021
@ijjk
Copy link
Member Author

ijjk commented Dec 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/wasm-test Change
buildDuration 24.1s 24.3s ⚠️ +232ms
buildDurationCached 4.3s 4.4s ⚠️ +63ms
nodeModulesSize 347 MB 347 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/wasm-test Change
/ failed reqs 0 0
/ total time (seconds) 4.042 4.101 ⚠️ +0.06
/ avg req/sec 618.46 609.64 ⚠️ -8.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.133 2.19 ⚠️ +0.06
/error-in-render avg req/sec 1171.99 1141.56 ⚠️ -30.43
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wasm-test Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wasm-test Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/wasm-test Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wasm-test Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wasm-test Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/wasm-test Change
buildDuration 25.8s 25.9s ⚠️ +39ms
buildDurationCached 4.3s 4.3s ⚠️ +50ms
nodeModulesSize 347 MB 347 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/wasm-test Change
/ failed reqs 0 0
/ total time (seconds) 4.07 4.086 ⚠️ +0.02
/ avg req/sec 614.23 611.92 ⚠️ -2.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.127 2.186 ⚠️ +0.06
/error-in-render avg req/sec 1175.55 1143.45 ⚠️ -32.1
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/wasm-test Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/wasm-test Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/wasm-test Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/wasm-test Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/wasm-test Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 1cc7056

@ijjk ijjk merged commit 836334e into vercel:canary Dec 7, 2021
@ijjk ijjk deleted the fix/wasm-test branch December 7, 2021 18:17
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants