Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing nothing as custom jest config #32328

Merged
merged 3 commits into from Feb 6, 2022

Conversation

midgleyc
Copy link
Contributor

@midgleyc midgleyc commented Dec 9, 2021

If you don't have any config, currently you need to pass {}, which is
less convenient than being able to pass nothing.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

If you don't have any config, currently you need to pass `{}`, which is
less convenient than being able to pass nothing.
@ijjk
Copy link
Member

ijjk commented Feb 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
buildDuration 15.6s 15.6s -43ms
buildDurationCached 6.1s 6s -69ms
nodeModulesSize 359 MB 359 MB ⚠️ +159 B
Page Load Tests Overall increase ✓
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
/ failed reqs 0 0
/ total time (seconds) 3.229 3.252 ⚠️ +0.02
/ avg req/sec 774.32 768.78 ⚠️ -5.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.36 1.345 -0.02
/error-in-render avg req/sec 1837.77 1858.23 +20.46
Client Bundles (main, webpack, commons)
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
buildDuration 19.1s 18.9s -185ms
buildDurationCached 6.1s 6s -35ms
nodeModulesSize 359 MB 359 MB ⚠️ +159 B
Page Load Tests Overall increase ✓
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
/ failed reqs 0 0
/ total time (seconds) 3.24 3.205 -0.04
/ avg req/sec 771.58 779.91 +8.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.376 1.369 -0.01
/error-in-render avg req/sec 1816.97 1826.67 +9.7
Client Bundles (main, webpack, commons)
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary midgleyc/next.js allow-no-custom-jest-config Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 401674d

ijjk
ijjk approved these changes Feb 6, 2022
Copy link
Member

@ijjk ijjk left a comment

Thanks for the PR!

@ijjk ijjk merged commit 7b19722 into vercel:canary Feb 6, 2022
7 of 8 checks passed
@midgleyc midgleyc deleted the allow-no-custom-jest-config branch Feb 6, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
If you don't have any config, currently you need to pass `{}`, which is
less convenient than being able to pass nothing.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants