Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resolve-url-loader into Next.js #32932

Merged
merged 9 commits into from Jan 2, 2022
Merged

Conversation

timneutkens
Copy link
Member

Fixes #32157

Moves resolve-url-loader into Next.js and strips out all features that are not used like rework support. Will reduce install size as well as allow for optimizing the approach in the near future. Also solves the issue where the postcss plugin it uses causes a warning.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes vercel#32157

Moves resolve-url-loader into Next.js and strips out all features that are not used like `rework` support. Will reduce install size as well as allow for optimizing the approach in the near future.
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

package.json Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Jan 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
buildDuration 13.9s 14.1s ⚠️ +184ms
buildDurationCached 3.1s 3.2s ⚠️ +28ms
nodeModulesSize 348 MB 348 MB -34.2 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
/ failed reqs 0 0
/ total time (seconds) 2.863 2.859 0
/ avg req/sec 873.29 874.51 +1.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.277 1.3 ⚠️ +0.02
/error-in-render avg req/sec 1957.29 1923.14 ⚠️ -34.15
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27 kB 27 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.74 kB 4.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
buildDuration 15.3s 15.2s -26ms
buildDurationCached 3.2s 3.2s -8ms
nodeModulesSize 348 MB 348 MB -34.2 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
/ failed reqs 0 0
/ total time (seconds) 2.853 2.854 0
/ avg req/sec 876.31 875.88 ⚠️ -0.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.299 1.287 -0.01
/error-in-render avg req/sec 1924.46 1943.03 +18.57
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.76 kB 4.76 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/issue-32157 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: ec751f4

@ijjk ijjk merged commit 88a5f26 into vercel:canary Jan 2, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postcss-resolve-url: postcss.plugin was deprecated
2 participants