Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add util for generating new tests/error documents #33001

Merged
merged 10 commits into from Jan 6, 2022
Merged

Add util for generating new tests/error documents #33001

merged 10 commits into from Jan 6, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 4, 2022

This adds a new util with scripts yarn new-test and yarn new-error to automate setting up new error documents and test suites.

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk added the type: next label Jan 4, 2022
@ijjk ijjk marked this pull request as ready for review January 4, 2022 22:08
@ijjk ijjk requested a review from styfle January 4, 2022 22:08
@ijjk

This comment has been minimized.

Sign in to view
styfle
styfle reviewed Jan 5, 2022
View reviewed changes
test/unit/example.txt Outdated Show resolved Hide resolved
styfle
styfle reviewed Jan 5, 2022
View reviewed changes
test/readme.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Jan 5, 2022
View reviewed changes
package.json Show resolved Hide resolved
@ijjk

This comment has been minimized.

Sign in to view
styfle
styfle previously approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

timneutkens
timneutkens previously approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Jan 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js add/plop Change
buildDuration 14.1s 14.3s ⚠️ +183ms
buildDurationCached 3.1s 3.2s ⚠️ +44ms
nodeModulesSize 348 MB 348 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/plop Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.89 2.881 -0.01
/ avg req/sec 864.94 867.68 +2.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.334 1.326 -0.01
/error-in-render avg req/sec 1873.47 1885.1 +11.63
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/plop Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/plop Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/plop Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/plop Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/plop Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js add/plop Change
buildDuration 15.7s 15.5s -144ms
buildDurationCached 3.2s 3.1s -56ms
nodeModulesSize 348 MB 348 MB -6 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/plop Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.895 2.866 -0.03
/ avg req/sec 863.68 872.15 +8.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.311 1.302 -0.01
/error-in-render avg req/sec 1906.75 1919.54 +12.79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/plop Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/plop Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/plop Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/plop Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/plop Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 52329f4

styfle
styfle approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ijjk ijjk merged commit efabf81 into vercel:canary Jan 6, 2022
@ijjk ijjk deleted the add/plop branch January 6, 2022 15:45
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens timneutkens left review comments

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @styfle @timneutkens