Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middleware at root in standalone mode #33053

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix middleware at root in standalone mode #33053

merged 2 commits into from
Jan 6, 2022

Conversation

skirsten
Copy link
Contributor

@skirsten skirsten commented Jan 6, 2022

Fixes a small bug that caused the build to crash if a _middleware is present at the root of the project and standalone mode is enabled.

@ijjk ijjk added the type: next label Jan 6, 2022
ijjk
ijjk requested changes Jan 6, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, good catch! Can we add a root middleware (can be a no-op) to this test to ensure we don't regress on this?

@skirsten skirsten force-pushed the fix/middleware-standalone-at-root branch from 44f0c57 to 4b36be7 Compare January 6, 2022 14:54
ijjk
ijjk approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Jan 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
buildDuration 20.8s 20.2s -539ms
buildDurationCached 4.8s 4.6s -135ms
nodeModulesSize 348 MB 348 MB ⚠️ +10 B
Page Load Tests Overall increase ✓
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.335 4.139 -0.2
/ avg req/sec 576.71 603.98 +27.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.078 1.97 -0.11
/error-in-render avg req/sec 1203.13 1268.85 +65.72
Client Bundles (main, webpack, commons)
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.1 kB 27.1 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 70.9 kB 70.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
buildDuration 21.7s 21.3s -411ms
buildDurationCached 4.7s 4.4s -311ms
nodeModulesSize 348 MB 348 MB ⚠️ +10 B
Page Load Tests Overall increase ✓
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.257 4.062 -0.19
/ avg req/sec 587.29 615.5 +28.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.006 2.049 ⚠️ +0.04
/error-in-render avg req/sec 1246.46 1220.4 ⚠️ -26.06
Client Bundles (main, webpack, commons)
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary skirsten/next.js fix/middleware-standalone-at-root Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: f9dc90d

@kodiakhq kodiakhq bot merged commit 6f5bfc1 into vercel:canary Jan 6, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 11, 2022
@teleaziz
Merge branch 'cms-builder-io-example' of github.com:teleaziz/next.js …
ce988af 
…into cms-builder-io-example

* 'cms-builder-io-example' of github.com:teleaziz/next.js: (22 commits)
  drop dynamic import with `ssr: false` on server-side (vercel#32606)
  next-swc: fix ssg code elimination when used in render (vercel#32709)
  Add Caveats section to custom error page (vercel#33160)
  v12.0.8-canary.20
  Allow dependencies to use environment variables in middlewares (vercel#33141)
  use a separate webpack runtime for middleware (vercel#33134)
  No info on environment variables in the src folder (vercel#33110) (vercel#33136)
  docs: minor text-copy cleanup (vercel#33120)
  Update swc (vercel#33063)
  Update next.config.js (vercel#33091)
  Adding Asset Component for Rich Text Renderer (vercel#32503)
  Update using-mdx.md (vercel#33077)
  v12.0.8-canary.19
  Fix middleware at root in standalone mode (vercel#33053)
  Add util for generating new tests/error documents (vercel#33001)
  Remove extra config from tailwind example (vercel#33062)
  Fix link for Next.js Analytics in docs (vercel#33049)
  Bump `@vercel/nft` to 0.17.2 (vercel#33048)
  Update deployment documentation. (vercel#32006)
  v12.0.8-canary.18
  ...
@vercel vercel locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skirsten @ijjk