Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade postcss #33142

Merged
merged 6 commits into from Jan 13, 2022
Merged

chore(deps): upgrade postcss #33142

merged 6 commits into from Jan 13, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 10, 2022

Fixes #33135

I also tried reducing the number of variants.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@romainmenke romainmenke mentioned this pull request Jan 10, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

ijjk
ijjk approved these changes Jan 13, 2022
@ijjk
Copy link
Member

ijjk commented Jan 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
buildDuration 14.1s 13.8s -215ms
buildDurationCached 3.1s 3.1s -1ms
nodeModulesSize 355 MB 354 MB -691 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
/ failed reqs 0 0
/ total time (seconds) 2.743 2.744 0
/ avg req/sec 911.34 911.03 ⚠️ -0.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.163 0
/error-in-render avg req/sec 2141.4 2150.31 +8.91
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
buildDuration 15.6s 15.4s -177ms
buildDurationCached 3.1s 3.2s ⚠️ +43ms
nodeModulesSize 355 MB 354 MB -691 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
/ failed reqs 0 0
/ total time (seconds) 2.74 2.747 ⚠️ +0.01
/ avg req/sec 912.42 910.01 ⚠️ -2.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.14 1.135 0
/error-in-render avg req/sec 2193.38 2203.07 +9.69
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.72 kB 4.72 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14 kB 14 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/upgrade-postcss Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 68e3b05

@kodiakhq kodiakhq bot merged commit 1dd053f into canary Jan 13, 2022
41 of 43 checks passed
@kodiakhq kodiakhq bot deleted the chore/upgrade-postcss branch Jan 13, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants