Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #33201

Merged
merged 15 commits into from Jan 14, 2022
Merged

Update swc #33201

merged 15 commits into from Jan 14, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 12, 2022

This PR is a bit big because AST definitions are modified recently because previous AST defs were too error-prone.
It will prevent plugin authors from making some common mistakes.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 12, 2022
@kdy1 kdy1 marked this pull request as ready for review Jan 12, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as draft Jan 13, 2022
@kdy1 kdy1 marked this pull request as ready for review Jan 13, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 14, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-2 Change
buildDuration 17.5s 18.1s ⚠️ +545ms
buildDurationCached 4.1s 3.8s -282ms
nodeModulesSize 355 MB 355 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-2 Change
/ failed reqs 0 0
/ total time (seconds) 3.732 3.748 ⚠️ +0.02
/ avg req/sec 669.83 667.03 ⚠️ -2.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.052 1.929 -0.12
/error-in-render avg req/sec 1218.06 1295.83 +77.77
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-2 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-2 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-2 Change
buildDuration 20s 20.3s ⚠️ +373ms
buildDurationCached 4s 3.9s -155ms
nodeModulesSize 355 MB 355 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-2 Change
/ failed reqs 0 0
/ total time (seconds) 3.794 3.829 ⚠️ +0.04
/ avg req/sec 659.02 652.93 ⚠️ -6.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.027 1.975 -0.05
/error-in-render avg req/sec 1233.56 1265.72 +32.16
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-2 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 1151556

@kodiakhq kodiakhq bot merged commit fd231a6 into vercel:canary Jan 14, 2022
42 of 44 checks passed
@kdy1 kdy1 deleted the swc-up-2 branch Jan 20, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
This PR is a bit big because AST definitions are modified recently because previous AST defs were too error-prone.
It will prevent plugin authors from making some common mistakes.


 - Closes vercel#33088
 - Closes vercel#31084
 - Closes vercel#33283
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants