Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getServerSideProps hanging in dev on early end #33366

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 16, 2022

This fixes the case where calling res.end() is getServerSideProps would cause the request to hang in development due to our Proxy around res causing internal ServerResponse fields to not be available (related post). I also migrated our getServerSideProps test suite to an e2e suite with a test for this case.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #15118
Fixes: #32824
Closes: #33129

@ijjk ijjk marked this pull request as ready for review January 16, 2022 16:05
@ijjk
Copy link
Member Author

ijjk commented Jan 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
buildDuration 17.9s 18.4s ⚠️ +412ms
buildDurationCached 3.9s 4s ⚠️ +132ms
nodeModulesSize 355 MB 355 MB ⚠️ +598 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
/ failed reqs 0 0
/ total time (seconds) 3.618 3.684 ⚠️ +0.07
/ avg req/sec 690.94 678.55 ⚠️ -12.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.657 1.722 ⚠️ +0.06
/error-in-render avg req/sec 1509.14 1452.21 ⚠️ -56.93
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
buildDuration 18.8s 19.2s ⚠️ +456ms
buildDurationCached 3.8s 4.2s ⚠️ +345ms
nodeModulesSize 355 MB 355 MB ⚠️ +598 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
/ failed reqs 0 0
/ total time (seconds) 3.509 3.561 ⚠️ +0.05
/ avg req/sec 712.55 702.14 ⚠️ -10.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.71 1.617 -0.09
/error-in-render avg req/sec 1461.68 1545.94 +84.26
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/gssp-early-end Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: d9d4bb0

@kodiakhq kodiakhq bot merged commit 02405e2 into vercel:canary Jan 16, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants