Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache for rsc pages #33438

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Disable cache for rsc pages #33438

merged 2 commits into from
Jan 18, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 18, 2022

Problem

When you navigate between pages, browsers will use bfcache to manage the page cache. RSC are fully dynamic and requires streaming to fill the suspended "content holes" before cache is well supported. But safari bfcache will stop it somehow, even chrome works well.

For safari it will only disable bfcache on when the cache header matches no-cache or no-store

x-ref: https://webkit.org/blog/427/webkit-page-cache-i-the-basics/

allowing HTTPS pages to be cached unless their response headers include “cache-control: no-store” or “cache-control: no-cache” which has become the canonical way for a selective organization to secure your content.

@ijjk
Copy link
Member

ijjk commented Jan 18, 2022

Failing test suites

Commit: 40afd83

test/e2e/basepath.test.ts

  • basePath > should navigate an absolute url
Expand output

● basePath › should navigate an absolute url

elementHandle.click: Timeout 30000ms exceeded.
=========================== logs ===========================
attempting click action
  waiting for element to be visible, enabled and stable
  element is visible, enabled and stable
  scrolling into view if needed
  done scrolling
  checking that element receives pointer events at (67.76,16.48)
  element does receive pointer events
  performing click action
  click action done
  waiting for scheduled navigations to finish
============================================================

  205 |
  206 |   text() {
> 207 |     return this.chain((el) => el.text()) as any
      |                       ^
  208 |   }
  209 |
  210 |   type(text) {

  at lib/browsers/playwright.ts:207:23
  at Object.<anonymous> (e2e/basepath.test.ts:388:13)

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
buildDuration 14.2s 14.2s ⚠️ +62ms
buildDurationCached 3.3s 3.1s -115ms
nodeModulesSize 352 MB 352 MB ⚠️ +97 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
/ failed reqs 0 0
/ total time (seconds) 2.888 2.969 ⚠️ +0.08
/ avg req/sec 865.66 842.15 ⚠️ -23.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.296 1.353 ⚠️ +0.06
/error-in-render avg req/sec 1929.14 1847.82 ⚠️ -81.32
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
buildDuration 15.7s 15.6s -79ms
buildDurationCached 3.2s 3.2s ⚠️ +32ms
nodeModulesSize 352 MB 352 MB ⚠️ +97 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
/ failed reqs 0 0
/ total time (seconds) 2.893 2.896 0
/ avg req/sec 864.08 863.18 ⚠️ -0.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.362 1.289 -0.07
/error-in-render avg req/sec 1835.11 1939.88 +104.77
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js disable-rsc-cache Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: cdcd0e6

@huozhi huozhi merged commit c367c72 into vercel:canary Jan 18, 2022
@huozhi huozhi deleted the disable-rsc-cache branch January 18, 2022 16:56
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants