Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade node-fetch #33466

Merged
merged 5 commits into from
Jan 19, 2022
Merged

chore(deps): upgrade node-fetch #33466

merged 5 commits into from
Jan 19, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 19, 2022

Fixes #33462

Tried upgrading to v3, but we rely on the timeout property:

Which was removed since it's non-standard:

https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md#the-timeout-option-was-removed

I wanted to keep this PR minimal, so I did not try to work around the above.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 19, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
buildDuration 14.9s 14.5s -378ms
buildDurationCached 3.3s 3.3s -24ms
nodeModulesSize 355 MB 355 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
/ failed reqs 0 0
/ total time (seconds) 3.009 3.026 ⚠️ +0.02
/ avg req/sec 830.92 826.22 ⚠️ -4.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.408 1.382 -0.03
/error-in-render avg req/sec 1775.03 1808.62 +33.59
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
buildDuration 18.1s 18.2s ⚠️ +98ms
buildDurationCached 3.3s 3.3s ⚠️ +4ms
nodeModulesSize 355 MB 355 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
/ failed reqs 0 0
/ total time (seconds) 2.979 2.973 -0.01
/ avg req/sec 839.16 840.9 +1.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.372 ⚠️ +0.01
/error-in-render avg req/sec 1829.1 1821.96 ⚠️ -7.14
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/upgrade-node-fetch Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: c1640f9

@Tosinkoa
Copy link

I'm still unable to solve 3 high severity vulnerabilities. What exactly is the recommended solution recommend here.

@balazsorban44
Copy link
Member Author

balazsorban44 commented Jan 24, 2022

For now, you can do npm i next@canary or wait for it to be released to latest

@vercel vercel locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node-fetch
3 participants