Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc #33514

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Update swc #33514

merged 5 commits into from
Jan 21, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 21, 2022 •
edited
Loading

This PR applies

This patch fixes possible regressions of destructuring pass.

This fixes react-otp-input

This fixes react-input-mask

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 21, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jan 21, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-7 Change
buildDuration 12.5s 12.3s -118ms
buildDurationCached 3.2s 3.2s -38ms
nodeModulesSize 355 MB 355 MB ⚠️ +14 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-7 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.966 2.959 -0.01
/ avg req/sec 842.88 844.85 +1.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.354 1.346 -0.01
/error-in-render avg req/sec 1846.1 1857.55 +11.45
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-7 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-7 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-7 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.87 kB 4.87 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.2 kB 14.2 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-7 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-7 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-7 Change
buildDuration 15.8s 15.7s -70ms
buildDurationCached 3.2s 3.2s -28ms
nodeModulesSize 355 MB 355 MB ⚠️ +14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-7 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.952 2.91 -0.04
/ avg req/sec 846.97 859.08 +12.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.336 1.358 ⚠️ +0.02
/error-in-render avg req/sec 1870.59 1841.17 ⚠️ -29.42
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-7 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-7 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-7 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.89 kB 4.89 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.2 kB 14.2 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-7 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-7 Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 48ccf12

@timneutkens timneutkens merged commit 8ff9785 into vercel:canary Jan 21, 2022
@timneutkens timneutkens deleted the swc-up-7 branch January 21, 2022 11:49
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @kodiakhq @natew
Update swc (vercel#33514)
8294472 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @timneutkens