Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the s from NextConfig #33560

Merged
merged 6 commits into from
Jan 23, 2022
Merged

Removed the s from NextConfig #33560

merged 6 commits into from
Jan 23, 2022

Conversation

paulnbrd
Copy link
Contributor

Removed the s of NextConfig
"This option was moved to the top level"
was before: "this options was moved to the top level"

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Just a little change, I mean I just saw it and it stressed me :)

Maybe you meant "These options were moved to the top level", but because there is only one option for now, I think without s , it makes more sense

Removed the s of
"This option was moved to the top level"
was before: "this options was moved to the top level"
paulnbrd and others added 2 commits January 22, 2022 17:35
@ijjk
Copy link
Member

ijjk commented Jan 22, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary paulnbrd/next.js patch-1 Change
buildDuration 11.8s 11.8s ⚠️ +20ms
buildDurationCached 3s 3.2s ⚠️ +216ms
nodeModulesSize 355 MB 355 MB ⚠️ +102 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary paulnbrd/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.791 2.98 ⚠️ +0.19
/ avg req/sec 895.68 839.05 ⚠️ -56.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.273 1.394 ⚠️ +0.12
/error-in-render avg req/sec 1963.9 1793.77 ⚠️ -170.13
Client Bundles (main, webpack, commons)
vercel/next.js canary paulnbrd/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary paulnbrd/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary paulnbrd/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary paulnbrd/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary paulnbrd/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary paulnbrd/next.js patch-1 Change
buildDuration 16.1s 15.7s -311ms
buildDurationCached 3.2s 3.2s ⚠️ +14ms
nodeModulesSize 355 MB 355 MB ⚠️ +102 B
Page Load Tests Overall increase ✓
vercel/next.js canary paulnbrd/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.958 2.92 -0.04
/ avg req/sec 845.26 856.16 +10.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.372 1.313 -0.06
/error-in-render avg req/sec 1822.6 1903.44 +80.84
Client Bundles (main, webpack, commons)
vercel/next.js canary paulnbrd/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary paulnbrd/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary paulnbrd/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary paulnbrd/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary paulnbrd/next.js patch-1 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 0891087

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 01cd69f into vercel:canary Jan 23, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* Removed the s

Removed the s of
"This option was moved to the top level"
was before: "this options was moved to the top level"

* Update packages/next/server/config-shared.ts

Co-authored-by: JJ Kasper <jj@jjsweb.site>

* Suggestion of @ijjk

* lint-fix

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants