Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web server as the request handler for edge SSR #33635

Merged
merged 30 commits into from Jan 26, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Jan 25, 2022

(#31506 for context)

This PR implements the minimum viable web server on top of the Next.js base server, and integrates it into our middleware (edge) SSR runtime to handle all the requests.

This also addresses problems like missing dynamic routes support in our current handler.

Note that this is the initial implementation with the assumption that the web server is running under minimal mode. Also later we can refactor the __server_context environment to properly passing the context via the constructor or methods.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 25, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Jan 25, 2022
Copy link
Member

@huozhi huozhi left a comment

Nice work 👍

@ijjk

This comment has been minimized.

huozhi
huozhi approved these changes Jan 25, 2022
@ijjk
Copy link
Member

ijjk commented Jan 26, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/504f Change
buildDuration 18.1s 15.6s -2.4s
buildDurationCached 4s 4s ⚠️ +59ms
nodeModulesSize 356 MB 356 MB ⚠️ +11.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/504f Change
/ failed reqs 0 0
/ total time (seconds) 4.134 3.768 -0.37
/ avg req/sec 604.75 663.43 +58.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.121 1.779 -0.34
/error-in-render avg req/sec 1178.66 1404.94 +226.28
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/504f Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/504f Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/504f Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/504f Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/504f Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/504f Change
buildDuration 19.1s 20.4s ⚠️ +1.3s
buildDurationCached 4.1s 4.1s ⚠️ +21ms
nodeModulesSize 356 MB 356 MB ⚠️ +11.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/504f Change
/ failed reqs 0 0
/ total time (seconds) 3.65 3.637 -0.01
/ avg req/sec 684.88 687.41 +2.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.729 1.648 -0.08
/error-in-render avg req/sec 1445.94 1517.13 +71.19
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/504f Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/504f Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/504f Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/504f Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/504f Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 4df0630

@leo
Copy link
Contributor

leo commented Feb 10, 2022

This change seems to have caused #34185.

natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
(vercel#31506 for context)

This PR implements the minimum viable web server on top of the Next.js base server, and integrates it into our middleware (edge) SSR runtime to handle all the requests.

This also addresses problems like missing dynamic routes support in our current handler.

Note that this is the initial implementation with the assumption that the web server is running under minimal mode. Also later we can refactor the `__server_context` environment to properly passing the context via the constructor or methods.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants