Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update security headers specification #33673

Merged
merged 6 commits into from Jan 26, 2022
Merged

chore(docs): update security headers specification #33673

merged 6 commits into from Jan 26, 2022

Conversation

j-mendez
Copy link
Contributor

@j-mendez j-mendez commented Jan 26, 2022

  1. fix details on how next handles security headers
  • note: check your HSTS at https://hstspreload.org
  • if your using headers in the config you need to add them below like

Screen Shot 2022-01-25 at 9 58 30 PM

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

fix details on how next handles security headers. 

* note: check your HSTS at https://hstspreload.org
Co-authored-by: Steven <steven@ceriously.com>
@j-mendez j-mendez requested a review from styfle Jan 26, 2022
styfle
styfle approved these changes Jan 26, 2022
Copy link
Member

@styfle styfle left a comment

Thanks!

@kodiakhq kodiakhq bot merged commit 9b98c5a into vercel:canary Jan 26, 2022
39 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
1. fix details on how next handles security headers

* note: check your HSTS at https://hstspreload.org
* if your using headers in the config you need to add them below like 

![Screen Shot 2022-01-25 at 9 58 30 PM](https://user-images.githubusercontent.com/8095978/151096692-1544e239-6229-4654-bf64-b01bfc13a601.png)



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


Co-authored-by: Steven <229881+styfle@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants