Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REMOVE: duplicate key in docs/testing.md #33681

Merged
merged 2 commits into from Jan 26, 2022

Conversation

ffan0811
Copy link
Contributor

@ffan0811 ffan0811 commented Jan 26, 2022

There is a duplicate key, testEnvironment in one of the examples that are located in docs/testing.md.
In my humble opinion, It is not good to have an error in examples.
My suggestion is we have only one key and it is up to developers what options they have for the testEnvironment.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ffan0811 ffan0811 changed the title REMOVE: duplicate key, testEnvironment in docs/testing.md REMOVE: duplicate key in docs/testing.md Jan 26, 2022
styfle
styfle approved these changes Jan 26, 2022
@kodiakhq kodiakhq bot merged commit c385d1b into vercel:canary Jan 26, 2022
39 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
There is a duplicate key, `testEnvironment` in one of the examples that are located in docs/testing.md.
In my humble opinion, It is not good to have an error in examples.
My suggestion is we have only one key and it is up to developers what options they have for the `testEnvironment`.

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
@ffan0811 ffan0811 deleted the fix/duplicate-key branch Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants