Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of amphtml-validator #33967

Merged
merged 3 commits into from Feb 4, 2022

Conversation

@ijjk ijjk added created-by: Next.js team type: next labels Feb 4, 2022
@ijjk ijjk marked this pull request as ready for review Feb 4, 2022
@ijjk ijjk requested review from huozhi, shuding and timneutkens as code owners Feb 4, 2022
@ijjk ijjk requested review from styfle and padmaia Feb 4, 2022
padmaia
padmaia approved these changes Feb 4, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 4, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
buildDuration 15.7s 19.2s ⚠️ +3.5s
buildDurationCached 3.9s 7.5s ⚠️ +3.6s
nodeModulesSize 359 MB 359 MB ⚠️ +13.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
/ failed reqs 0 0
/ total time (seconds) 3.989 3.982 -0.01
/ avg req/sec 626.75 627.85 +1.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.083 2.173 ⚠️ +0.09
/error-in-render avg req/sec 1200.2 1150.43 ⚠️ -49.77
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
buildDuration 20.2s 24s ⚠️ +3.8s
buildDurationCached 3.9s 7.7s ⚠️ +3.8s
nodeModulesSize 359 MB 359 MB ⚠️ +13.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
/ failed reqs 0 0
/ total time (seconds) 3.86 3.935 ⚠️ +0.08
/ avg req/sec 647.62 635.33 ⚠️ -12.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.126 2.129 0
/error-in-render avg req/sec 1175.67 1174.42 ⚠️ -1.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/amphtml-validator Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 344e90d

@ijjk ijjk merged commit 06b2630 into vercel:canary Feb 4, 2022
40 of 42 checks passed
@ijjk ijjk deleted the update/amphtml-validator branch Feb 4, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
* Update to latest version of amphtml-validator

* update compiled

* bump compiled
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants