Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify GitHub action (bot) comments #34546

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 18, 2022

For anyone landing on this PR, if you are new to contributing to open source, here is a helpful video with some good tips: How to Contribute to Open Source (Next.js)

We use two GitHub Actions (here bots) to help us maintain the project better:

  1. Stalebot

When an issue is triaged, we look for a reproduction and clear steps to reproduce the reported issue. This helps us identify bugs easier, which will result in a quicker resolution of the bug.

Skipping these steps could mean that we will not be able to investigate. In these cases, the issue will receive a please add a complete reproduction label, that indicates to the original poster (or those following along in the issue) that we would like them to post the missed steps. Unless that happens within 30 days, we are marking the issue as stale. A day after, the issue is automatically closed.

If someone finds this now-closed issue later, through the Stalebot we encourage that a new issue will be opened and reference the old one if it holds important/relevant contextual information. The reason is that newer releases might have already fixed the issue that was reported in the first place. This is indicated in the bug report issue template forms.

  1. Lockbot

This bot is similar to Stalebot, but it strictly operates on already closed/resolved issues, it never closes ongoing/open issue discussions.

An issue can be closed for multiple reasons. It either has been closed by the original poster because they found the solution, or a PR merge included a fix in a recent Next.js release. It is important to look for the reason before commenting.

If the issue was seemingly locked by accident, through the Lockbot comment we encourage that a new issue will be opened and reference the old one if it holds important/relevant contextual information. The reason is that newer releases might have already fixed the issue that was reported in the first place. This is indicated in the bug report issue template forms.

Important: Issues can be closed/locked by accident, and we encourage everyone to feel welcome opening a new case and reference back to the old issue. Our team values everyone's opinion and we would like to make sure that we resolve any confusion in each individual case.

Note that this message should only appear on already closed issues
huozhi
huozhi previously approved these changes Feb 18, 2022
ijjk
ijjk previously approved these changes Feb 18, 2022
.github/workflows/lock.yml Outdated Show resolved Hide resolved
.github/workflows/stale.yml Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
@balazsorban44 balazsorban44 dismissed stale reviews from ijjk and huozhi via 14bd9d7 February 18, 2022 16:00
@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
buildDuration 18.2s 18.1s -104ms
buildDurationCached 7.1s 7.2s ⚠️ +107ms
nodeModulesSize 359 MB 359 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
/ failed reqs 0 0
/ total time (seconds) 3.505 3.531 ⚠️ +0.03
/ avg req/sec 713.27 708.07 ⚠️ -5.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.57 1.587 ⚠️ +0.02
/error-in-render avg req/sec 1592.14 1575.15 ⚠️ -16.99
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
buildDuration 22.1s 21.7s -389ms
buildDurationCached 7.2s 7.2s -75ms
nodeModulesSize 359 MB 359 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
/ failed reqs 0 0
/ total time (seconds) 3.515 3.561 ⚠️ +0.05
/ avg req/sec 711.26 701.97 ⚠️ -9.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.587 1.674 ⚠️ +0.09
/error-in-render avg req/sec 1575.21 1493.83 ⚠️ -81.38
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/clear-up-bot-comments Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5c9cfd9

@kodiakhq kodiakhq bot merged commit aa35aa1 into canary Feb 18, 2022
@kodiakhq kodiakhq bot deleted the chore/clear-up-bot-comments branch February 18, 2022 16:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants