Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added styled-components & replay support in swc #34647

Merged
merged 3 commits into from
Feb 21, 2022
Merged

added styled-components & replay support in swc #34647

merged 3 commits into from
Feb 21, 2022

Conversation

mxgnus-de
Copy link
Contributor

styled-components & relay is supported in swr since nextjs 12.1.
See https://nextjs.org/blog/next-12-1#improved-swc-support

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@mxgnus-de
added styled-components & replay support in swr
d4fc7a0 
styled-components & relay is supported in swr since nextjs 12.1
ijjk
ijjk approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijjk ijjk changed the title added styled-components & replay support in swr added styled-components & replay support in swc Feb 21, 2022
@ijjk ijjk merged commit 7d98537 into vercel:canary Feb 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxgnus-de @ijjk