Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update swc #34878

Merged
merged 9 commits into from
Mar 1, 2022
Merged

feat(next-swc): Update swc #34878

merged 9 commits into from
Mar 1, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 28, 2022

This PR updates crates to swc-project/swc@ba3fdad

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 28, 2022
@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as ready for review March 1, 2022 03:02
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as draft March 1, 2022 05:04
@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as ready for review March 1, 2022 05:21
@ijjk
Copy link
Member

ijjk commented Mar 1, 2022

Failing test suites

Commit: 600142a

yarn testheadless test/production/middleware-typescript/test/index.test.ts

  • should set-up next > should have built and started
Expand output

● should set-up next › should have built and started

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  11 |   let next: NextInstance
  12 |
> 13 |   beforeAll(async () => {
     |   ^
  14 |     next = await createNext({
  15 |       files: {
  16 |         pages: new FileRef(join(appDir, 'pages')),

  at production/middleware-typescript/test/index.test.ts:13:3
  at Object.<anonymous> (production/middleware-typescript/test/index.test.ts:10:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  26 |     })
  27 |   })
> 28 |   afterAll(() => next.destroy())
     |                       ^
  29 |
  30 |   it('should have built and started', async () => {
  31 |     const html = await renderViaHTTP(next.url, '/interface/static')

  at production/middleware-typescript/test/index.test.ts:28:23

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Mar 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up Change
buildDuration 20.6s 20.9s ⚠️ +317ms
buildDurationCached 7.9s 7.9s ⚠️ +21ms
nodeModulesSize 372 MB 372 MB -8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up Change
/ failed reqs 0 0
/ total time (seconds) 4.406 4.391 -0.01
/ avg req/sec 567.4 569.38 +1.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.108 2.146 ⚠️ +0.04
/error-in-render avg req/sec 1186.07 1165.01 ⚠️ -21.06
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up Change
buildDuration 25s 25s -30ms
buildDurationCached 7.9s 8s ⚠️ +146ms
nodeModulesSize 372 MB 372 MB -8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up Change
/ failed reqs 0 0
/ total time (seconds) 4.241 4.323 ⚠️ +0.08
/ avg req/sec 589.54 578.25 ⚠️ -11.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.071 2.135 ⚠️ +0.06
/error-in-render avg req/sec 1207.09 1171.01 ⚠️ -36.08
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 528 B 528 B
Overall change 1.6 kB 1.6 kB
Commit: f9e845e

@ijjk ijjk merged commit 6814852 into vercel:canary Mar 1, 2022
@kdy1 kdy1 deleted the swc-up branch March 30, 2022 14:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants