Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript 4.6.2 randomUUID() #34976

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 2, 2022

This PR fixes the latest version of typescript (4.6.2) that was failing with the following:

Type error: Overload signatures must all be optional or required.
  207 |       array: T
  208 |     ): T
> 209 |     randomUUID?(): string
      |     ^
  210 |   }
  211 | }

https://github.com/vercel/next.js/runs/5376232868?check_suite_focus=true#step:8:106

huozhi
huozhi previously approved these changes Mar 2, 2022
huozhi
huozhi previously approved these changes Mar 2, 2022
@ijjk
Copy link
Member

ijjk commented Mar 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
buildDuration 14.4s 14.5s ⚠️ +101ms
buildDurationCached 5.5s 6s ⚠️ +409ms
nodeModulesSize 372 MB 372 MB ⚠️ +65.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
/ failed reqs 0 0
/ total time (seconds) 2.823 2.963 ⚠️ +0.14
/ avg req/sec 885.46 843.78 ⚠️ -41.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.296 1.314 ⚠️ +0.02
/error-in-render avg req/sec 1929.09 1902.13 ⚠️ -26.96
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.06 kB 5.06 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
buildDuration 17.4s 17.1s -267ms
buildDurationCached 5.5s 5.6s ⚠️ +30ms
nodeModulesSize 372 MB 372 MB ⚠️ +65.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
/ failed reqs 0 0
/ total time (seconds) 2.961 2.834 -0.13
/ avg req/sec 844.35 882.06 +37.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.333 1.333
/error-in-render avg req/sec 1875.2 1875.05 ⚠️ -0.15
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-typescript-crypto-random-uuid Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 1b373e7

@kodiakhq kodiakhq bot merged commit 937ab16 into canary Mar 2, 2022
@kodiakhq kodiakhq bot deleted the fix-typescript-crypto-random-uuid branch March 2, 2022 21:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants