-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add Tina CMS blog starter #35045
Conversation
Added the changes requested, and fix the Next starter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've deployed this, we could add it to the README as a demo URL 😄
I actually don't have it deployed. I can come back around once we figure out where it should live (tinacms, my repo etc) and I will add an update to the README.md |
Looks like two small issues in CI:
|
Yup @leerob looks like those were the changes you made to the Avatar. I’ll take a look tomorrow, see why it’s not building. |
Oh I see the problem the end should be a } but we have a ) on the image width and heights |
Change from ) to }
Fixing height and width props
Should be all set now👍 |
@perkinsjr Could you address the linting issues, otherwise, this would be ok to merge. See: https://github.com/vercel/next.js/runs/5430503399?check_suite_focus=true |
This should be good to go now. |
Documentation / Examples