Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update crates #35133

Merged
merged 18 commits into from
Mar 11, 2022
Merged

feat(next-swc): Update crates #35133

merged 18 commits into from
Mar 11, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 8, 2022

This PR updates crates related to ecmascript to swc-project/swc@d62ef64

I'll update css crates separately.

This PR also reduces the size of binary.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 8, 2022
@kdy1 kdy1 marked this pull request as draft March 8, 2022 09:55
@kdy1 kdy1 marked this pull request as ready for review March 8, 2022 10:07
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as draft March 8, 2022 10:44
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as ready for review March 9, 2022 03:57
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 9, 2022

Failing test suites

Commit: da440cb

yarn testheadless test/production/next/jest/index.test.ts

  • next/jest > should work
Expand output

● next/jest › should work

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

   6 |   let next: NextInstance
   7 |
>  8 |   beforeAll(async () => {
     |   ^
   9 |     next = await createNext({
  10 |       files: {
  11 |         'public/vercel.svg':

  at production/next/jest/index.test.ts:8:3
  at Object.<anonymous> (production/next/jest/index.test.ts:5:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  119 |     })
  120 |   })
> 121 |   afterAll(() => next.destroy())
      |                       ^
  122 |
  123 |   it('should work', async () => {
  124 |     const html = await renderViaHTTP(next.url, '/')

  at production/next/jest/index.test.ts:121:23

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

@kdy1 kdy1 changed the title feat(next-swc): Update ES crates feat(next-swc): Update crates Mar 11, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-up-2 Change
buildDuration 20.8s 20.7s -109ms
buildDurationCached 7.9s 7.8s -61ms
nodeModulesSize 378 MB 378 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-2 Change
/ failed reqs 0 0
/ total time (seconds) 4.398 4.481 ⚠️ +0.08
/ avg req/sec 568.47 557.95 ⚠️ -10.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.252 2.238 -0.01
/error-in-render avg req/sec 1110.26 1117.14 +6.88
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-2 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-2 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-2 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-up-2 Change
buildDuration 24.8s 25.3s ⚠️ +459ms
buildDurationCached 7.8s 7.8s ⚠️ +29ms
nodeModulesSize 378 MB 378 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-2 Change
/ failed reqs 0 0
/ total time (seconds) 4.431 4.493 ⚠️ +0.06
/ avg req/sec 564.26 556.42 ⚠️ -7.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.265 2.277 ⚠️ +0.01
/error-in-render avg req/sec 1103.74 1098.01 ⚠️ -5.73
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-2 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-2 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-2 Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: dd0e636

@kodiakhq kodiakhq bot merged commit e57d621 into vercel:canary Mar 11, 2022
@kdy1 kdy1 deleted the swc-up-2 branch March 11, 2022 05:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants