Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update styling support for streaming #35375

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 16, 2022

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@huozhi huozhi marked this pull request as ready for review March 16, 2022 16:59
@@ -68,4 +68,6 @@ Currently, data fetching within `Suspense` boundaries on the server side is not

#### Styling

The Next.js team is working on support for `styled-jsx` and CSS modules in streaming SSR. Stay tuned for updates.
So far only `styled-jsx` is supported with streaming. The Next.js team is working on support for CSS modules and other CSS solutions in streaming SSR. Stay tuned for updates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to a RFC or Discussion for the updates?

@@ -68,4 +68,6 @@ Currently, data fetching within `Suspense` boundaries on the server side is not

#### Styling

The Next.js team is working on support for `styled-jsx` and CSS modules in streaming SSR. Stay tuned for updates.
So far only `styled-jsx` is supported with streaming. The Next.js team is working on support for CSS modules and other CSS solutions in streaming SSR. Stay tuned for updates.
Copy link
Contributor

@devknoll devknoll Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unstable_useFlushEffects should be sufficient for any library that follows the recommended upgrade guide. It's just that styled-jsx support is built-in and happens to be the only one (as far as I know) that has done so.

@huozhi huozhi marked this pull request as draft March 17, 2022 17:42
@huozhi
Copy link
Member Author

huozhi commented Mar 23, 2022

@styfle @devknoll Now the built-in styling solutions (global css, css modules and styled-jsx) are supported, for other CSS solutions I think we need some time to investigate to see if they can leverage useFlushEffects to support them. I'll follow up that in another thread.

@huozhi huozhi marked this pull request as ready for review March 23, 2022 10:40
styfle
styfle previously approved these changes Mar 23, 2022
Co-authored-by: Shu Ding <g@shud.in>
@huozhi huozhi requested a review from shuding March 26, 2022 12:39
@kodiakhq kodiakhq bot merged commit 27d23f5 into vercel:canary Mar 26, 2022
@huozhi huozhi deleted the docs/react-18 branch March 26, 2022 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants