Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useStatic404 condition #35749

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Fix useStatic404 condition #35749

merged 5 commits into from
Mar 30, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 30, 2022

Static optimization is now supported with concurrent features, this PR fixes the condition for useStatic404.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

timneutkens
timneutkens previously approved these changes Mar 30, 2022
ijjk
ijjk previously approved these changes Mar 30, 2022
@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@kodiakhq kodiakhq bot merged commit 0409b38 into vercel:canary Mar 30, 2022
@ijjk
Copy link
Member

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/19dc Change
buildDuration 20.3s 20.6s ⚠️ +314ms
buildDurationCached 7.8s 8s ⚠️ +208ms
nodeModulesSize 467 MB 467 MB -42 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/19dc Change
/ failed reqs 0 0
/ total time (seconds) 4.369 4.391 ⚠️ +0.02
/ avg req/sec 572.2 569.36 ⚠️ -2.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.252 2.172 -0.08
/error-in-render avg req/sec 1110.03 1151.07 +41.04
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/19dc Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/19dc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/19dc Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.05 kB 3.05 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.7 kB 15.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/19dc Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/19dc Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary shuding/next.js shu/19dc Change
buildDuration 25s 25.3s ⚠️ +321ms
buildDurationCached 8s 7.9s -139ms
nodeModulesSize 467 MB 467 MB -42 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/19dc Change
/ failed reqs 0 0
/ total time (seconds) 4.485 4.424 -0.06
/ avg req/sec 557.4 565.1 +7.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.25 2.234 -0.02
/error-in-render avg req/sec 1111.18 1119.21 +8.03
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/19dc Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/19dc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/19dc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.8 kB 15.8 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/19dc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/19dc Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: e1ed499

kodiakhq bot pushed a commit that referenced this pull request Mar 31, 2022
…5762)

This fixes `router.isReady` being incorrect in dev mode due to the `isAutoExport` field being false from `hasConcurrentFeatures` being flagged similar to the static 404 in #35749. While investigating this I also noticed we aren't properly detecting react 18 when no `next.config.js` is present. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`

Fixes: #35754
x-ref: #35749
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants