Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename app paths folder #37146

Merged
merged 5 commits into from
May 25, 2022
Merged

Rename app paths folder #37146

merged 5 commits into from
May 25, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 24, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 24, 2022
@ijjk ijjk marked this pull request as ready for review May 24, 2022 00:49
@ijjk
Copy link
Member Author

ijjk commented May 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/views-app-dir Change
buildDuration 18.6s 18.6s -91ms
buildDurationCached 7.6s 7.6s -76ms
nodeModulesSize 494 MB 494 MB -499 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/views-app-dir Change
/ failed reqs 0 0
/ total time (seconds) 4.566 4.509 -0.06
/ avg req/sec 547.58 554.42 +6.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.596 1.566 -0.03
/error-in-render avg req/sec 1566.57 1595.94 +29.37
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/views-app-dir Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/views-app-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/views-app-dir Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/views-app-dir Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/views-app-dir Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/views-app-dir Change
buildDuration 20.6s 20.6s ⚠️ +24ms
buildDurationCached 7.6s 7.5s -62ms
nodeModulesSize 494 MB 494 MB -499 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/views-app-dir Change
/ failed reqs 0 0
/ total time (seconds) 4.515 4.479 -0.04
/ avg req/sec 553.72 558.14 +4.42
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.584 1.583 0
/error-in-render avg req/sec 1577.91 1579.57 +1.66
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/views-app-dir Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/views-app-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/views-app-dir Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/views-app-dir Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/views-app-dir Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: b12cc85

ijjk added 3 commits May 24, 2022 10:19
# Conflicts:
#	packages/next/build/webpack-config.ts
#	packages/next/build/webpack/plugins/flight-manifest-plugin.ts
@timneutkens timneutkens merged commit b68d9ea into vercel:canary May 25, 2022
@timneutkens timneutkens deleted the update/views-app-dir branch May 25, 2022 09:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants