Update GitHub Pages deployment example. #37282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
timneutkens,
ijjk,
shuding,
steven-tey and
balazsorban44
as code owners
ijjk
added
examples
ijjk
reviewed
May 29, 2022
| @@ -1,45 +0,0 @@ | |||
| # gh-pages Hello World example | |||
There was a problem hiding this comment.
Do we want to leave this README and have a note linking to the new name similar to https://github.com/vercel/next.js/blob/canary/examples/with-material-ui/README.md
There was a problem hiding this comment.
I'm leaning towards no. Here's why: we have so many examples now, we're almost reaching "folder debt" where I'd rather have a low probability 404 on gh-pages than harder scanning through the directory. I also instinctively searched for "github" and didn't find anything, so I almost missed this example entirely.
Open to other thoughts.
ijjk
approved these changes
May 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified it's working: https://leerob.github.io/gh-pages-test/