Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding example with-fingerprintjs-pro for identifying visitors #37549

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Adding example with-fingerprintjs-pro for identifying visitors #37549

merged 10 commits into from
Jun 22, 2022

Conversation

ilfa
Copy link
Contributor

@ilfa ilfa commented Jun 8, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Deployed on https://with-fingerprintjs-pro.vercel.app/

@ijjk ijjk added the examples Issue/PR related to examples label Jun 8, 2022
balazsorban44
balazsorban44 requested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, made a small suggestion to comply with our contribution guidelines

@ilfa ilfa requested a review from balazsorban44 June 16, 2022 08:48
@ilfa
Copy link
Contributor Author

ilfa commented Jun 22, 2022

Hello @balazsorban44!
Do I need to update the branch?

balazsorban44
balazsorban44 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you!

@kodiakhq kodiakhq bot merged commit a4117c9 into vercel:canary Jun 22, 2022
@ilfa ilfa deleted the add/example/with-fingerprintjs branch June 24, 2022 15:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilfa @balazsorban44 @ijjk