Convert basic-css example to TypeScript #38091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxproske
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
balazsorban44
approved these changes
Jun 29, 2022
huozhi
reviewed
Jun 30, 2022
| @@ -1,9 +1,11 @@ | |||
| import styles from '../styles.module.css' | |||
|
|
|||
| export default function Home() { | |||
| const Home = () => { | |||
There was a problem hiding this comment.
Would be good to keep here as before with the function name, that's also helpful for react devtools and align with react docs
There was a problem hiding this comment.
I agree. I considered this my stylistic preference, but if this is what the React docs do as well, I think I would prefer function over const as well, so the declaration and export aren't split
11 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted basic CSS example over to TypeScript to match the Contribution guidelines.
Documentation / Examples
pnpm lint