Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edge-runtime.md #38271

Merged
merged 7 commits into from Jul 6, 2022
Merged

Update edge-runtime.md #38271

merged 7 commits into from Jul 6, 2022

Conversation

zanechua
Copy link
Contributor

@zanechua zanechua commented Jul 3, 2022

console.log does not currently print all the environment variables that the edge runtime should have access to. I am assuming that this is a technical challenge or it only accesses the variables it needs if they are declared. This can be confusing when trying to implement as you would make the assumption that printing process.env should display all accessible environment variable.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

leerob
leerob previously approved these changes Jul 4, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 3b3d249 into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants