Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Convert api-routes-cors example to TypeScript #38356

Merged

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Jul 6, 2022

Convert api-routes-cors example to TypeScript to match Contribution docs.

  • Update CORS configuration to match the middleware Next.js docs
  • Allow POST requests as per instructions in index.tsx: "make a POST / GET / OPTIONS request to /api/cors"

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 6, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 changed the title chore(examples): Convert api-routes-cores example to TypeScript chore(examples): Convert api-routes-cors example to TypeScript Jul 6, 2022
@kodiakhq kodiakhq bot merged commit 5145c2d into vercel:canary Jul 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants