Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chalk@5 #41730

Closed
wants to merge 3 commits into from
Closed

Conversation

matamatanot
Copy link
Contributor

@matamatanot matamatanot commented Oct 24, 2022

ref #11268

Next.js@13 drops IE support.
chalk can be upgraded to v5.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@matamatanot
Copy link
Contributor Author

Some Sindre's packages are used, but some of them (find-up, gzip-size) are not latest versions.
Is it because for Pure ESM only output? Upgrading seems difficult.
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

@ijjk ijjk force-pushed the canary branch 3 times, most recently from df8579c to 47e5ebe Compare October 25, 2022 16:15
@ijjk ijjk force-pushed the canary branch 2 times, most recently from e078ebe to 6b863fe Compare December 2, 2022 05:49
@ijjk ijjk requested a review from feedthejim as a code owner March 2, 2023 23:39
@ijjk ijjk requested review from a team as code owners May 4, 2023 16:19
@timneutkens
Copy link
Member

Going to close this PR as it's stale and the tests are failing. Overall it's not particularly needed to upgrade right now btw.

@timneutkens timneutkens closed this May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants