Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed output mode on app directory test application #43607

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Dec 1, 2022

Disables standalone output mode for app directory tests until some issues are resolved around it. Should be re-enabled once the issues have been resolved.

x-ref: https://vercel.slack.com/archives/C035J346QQL/p1669829521120779

@wyattjoh wyattjoh added the area: app App directory (appDir: true) label Dec 1, 2022
@balazsorban44 balazsorban44 merged commit 07d52ce into vercel:canary Dec 1, 2022
@wyattjoh wyattjoh deleted the wyattjoh/app-dir-test-output branch December 1, 2022 17:11
ijjk added a commit that referenced this pull request Dec 2, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was working as expected x-ref: #43618

ijjk added a commit that referenced this pull request Dec 2, 2022
This test was ensuring `app` directory is working correctly with
`output: 'standalone'`. Instead of removing config we should
conditionally set it for the test.

Reverts #43607

x-ref:
https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699
x-ref:
https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: app App directory (appDir: true)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants