Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty module from the next dynamic loader #44873

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Handle empty module from the next dynamic loader #44873

merged 2 commits into from
Jan 14, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 14, 2023 •
edited

Bug

x-ref: #42298 (comment)

could possibly caused by the resolved module is undefined

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 14, 2023
@huozhi huozhi marked this pull request as ready for review January 14, 2023 00:24
@ijjk ijjk merged commit 3758716 into vercel:canary Jan 14, 2023
@huozhi huozhi deleted the app/handle-undefined-dynamic-module branch January 14, 2023 00:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk