Remove transform-decorators-legacy plugin from Ant Design Example #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezdemkovski
changed the title
HaNdTriX
approved these changes
Sep 22, 2018
|
Note that #5263 (comment) says this concept is needed for global styles to work and has provided something for next 7. |
|
@timneutkens @yakovlevyuri Hey, I think this pull request may be undesirable. I was also very uncertain what transform-decorators-legacy did and almost did a pull request myself because I couldn't tell it did anything when I removed it. But this comment over here implies that the transform-decorators concept actually provides a benefit. Could you advise what you think should be in the final merge between this and that pull? I suspect the other pull is probably the right thing to keep. #5263 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove transform-decorators-legacy plugin from
with-ant-designexample and Bump deps