Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for with-ant-design-less for next7.0 #5263

Merged
merged 2 commits into from
Sep 23, 2018
Merged

Conversation

andresleoon
Copy link
Contributor

I have fixed about the modify ant theme for next7.0 because is not working now, So I just add plugin-proposal-decorators and set the babel config , and delete the deprecated babel-plugin-transform-decorators-legacy, I will apreciate for accept that pull request, thanks next.js Team :)

babel-plugin-transform-decorators-legacy does not exist in babel 7 in replace use @babel/plugin-proposal-decorators
Acording the last commit please,  test this example , will be work .
@timneutkens timneutkens merged commit ce8b301 into vercel:canary Sep 23, 2018
@andresleoon
Copy link
Contributor Author

thanks :)

@Enalmada
Copy link
Contributor

@andresleoon What happens if babel-plugin-transform-decorators-legacy is completely removed? There is a pull request to completely remove it here and I am curious which is the right way to go:
#5232

@andresleoon
Copy link
Contributor Author

andresleoon commented Sep 25, 2018

@andresleoon What happens if babel-plugin-transform-decorators-legacy is completely removed? There is a pull request to completely remove it here and I am curious which is the right way to go:
#5232

@Enalmada does not happen nothing however the Customize Theme from Ant Design https://ant.design/docs/react/customize-theme does not work, that's why I put that plugin-proposal-decorators for customize theme for Ant Design works with custom colors, etc.... thanks

@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants