Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional appDir checks #54788

Merged
merged 5 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub async fn get_app_entries(
server_compile_time_info: Vc<CompileTimeInfo>,
next_config: Vc<NextConfig>,
) -> Result<Vc<AppEntries>> {
let app_dir = find_app_dir_if_enabled(project_root, next_config);
let app_dir = find_app_dir_if_enabled(project_root);

let Some(&app_dir) = app_dir.await?.as_ref() else {
return Ok(AppEntries::cell(AppEntries {
Expand Down
8 changes: 1 addition & 7 deletions packages/next-swc/crates/next-core/src/app_structure.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,7 @@ pub async fn find_app_dir(project_path: Vc<FileSystemPath>) -> Result<Vc<OptionA
/// Finds and returns the [DirectoryTree] of the app directory if enabled and
/// existing.
#[turbo_tasks::function]
pub async fn find_app_dir_if_enabled(
project_path: Vc<FileSystemPath>,
next_config: Vc<NextConfig>,
) -> Result<Vc<OptionAppDir>> {
if !*next_config.app_dir().await? {
return Ok(Vc::cell(None));
}
pub async fn find_app_dir_if_enabled(project_path: Vc<FileSystemPath>) -> Result<Vc<OptionAppDir>> {
Ok(find_app_dir(project_path))
}

Expand Down
13 changes: 0 additions & 13 deletions packages/next-swc/crates/next-core/src/next_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ pub enum LoaderItem {
#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize, TraceRawVcs)]
#[serde(rename_all = "camelCase")]
pub struct ExperimentalConfig {
pub app_dir: Option<bool>,
pub server_components_external_packages: Option<Vec<String>>,
pub turbo: Option<ExperimentalTurboConfig>,
pub allowed_revalidate_header_keys: Option<Vec<String>>,
Expand Down Expand Up @@ -527,18 +526,6 @@ impl NextConfig {
))
}

#[turbo_tasks::function]
pub async fn app_dir(self: Vc<Self>) -> Result<Vc<bool>> {
Ok(Vc::cell(
self.await?
.experimental
.app_dir
.as_ref()
.cloned()
.unwrap_or_default(),
))
}

#[turbo_tasks::function]
pub async fn env(self: Vc<Self>) -> Result<Vc<EnvMap>> {
// The value expected for env is Record<String, String>, but config itself
Expand Down
2 changes: 1 addition & 1 deletion packages/next-swc/crates/next-dev/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -348,12 +348,12 @@
.iter()
.map(|r| match r {
EntryRequest::Relative(p) => {
Request::relative(Value::new(p.clone().into()), Vc::<String>::empty(), false)

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / lint / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (11) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (12) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (10) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (6) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (7) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (9) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (8) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 351 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / report-test-results / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead
}
EntryRequest::Module(m, p) => Request::module(
m.clone(),
Value::new(p.clone().into()),
Vc::<String>::empty(),

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / lint / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (11) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (12) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (10) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (6) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (7) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (9) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (8) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 356 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / report-test-results / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead
),
})
.collect();
Expand Down Expand Up @@ -388,7 +388,7 @@
next_config,
server_addr,
);
let app_dir = find_app_dir_if_enabled(project_path, next_config);
let app_dir = find_app_dir_if_enabled(project_path);
let app_source = create_app_source(
app_dir,
project_path,
Expand Down Expand Up @@ -440,7 +440,7 @@
));
let source = Vc::upcast(
PrefixedRouterContentSource {
prefix: Vc::<String>::empty(),

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test experimental turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / lint / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (11) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (12) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (10) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (6) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (5) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (7) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (4) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test prod (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (9) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (2) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test integration (8) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (1) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / test dev (3) / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead

Check warning on line 443 in packages/next-swc/crates/next-dev/src/lib.rs

View workflow job for this annotation

GitHub Actions / report-test-results / build

use of deprecated associated function `turbo_tasks::primitives::<impl turbo_tasks::Vc<std::string::String>>::empty`: use Default::default() instead
routes: vec![
("__turbopack__".to_string(), introspect),
("__turbo_tasks__".to_string(), viz),
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/build/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1987,7 +1987,7 @@ startServer({
port: currentPort,
allowRetry: false,
keepAliveTimeout,
useWorkers: !!nextConfig.experimental?.appDir,
useWorkers: true,
}).catch((err) => {
console.error(err);
process.exit(1);
Expand Down
9 changes: 2 additions & 7 deletions packages/next/src/cli/next-dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { CliCommand } from '../lib/commands'
import { getProjectDir } from '../lib/get-project-dir'
import { CONFIG_FILES, PHASE_DEVELOPMENT_SERVER } from '../shared/lib/constants'
import path from 'path'
import { defaultConfig, NextConfigComplete } from '../server/config-shared'
import { NextConfigComplete } from '../server/config-shared'
import { traceGlobals } from '../trace/shared'
import { Telemetry } from '../telemetry/storage'
import loadConfig from '../server/config'
Expand Down Expand Up @@ -352,12 +352,7 @@ const nextDev: CliCommand = async (argv) => {
})

const distDir = path.join(dir, rawNextConfig.distDir || '.next')
const { pagesDir, appDir } = findPagesDir(
dir,
typeof rawNextConfig?.experimental?.appDir === 'undefined'
? !!defaultConfig.experimental?.appDir
: !!rawNextConfig.experimental?.appDir
)
const { pagesDir, appDir } = findPagesDir(dir, true)
const telemetry = new Telemetry({
distDir,
})
Expand Down
3 changes: 0 additions & 3 deletions packages/next/src/server/config-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,6 @@ const configSchema = {
},
] as any,
},
appDir: {
type: 'boolean',
},
serverActions: {
type: 'boolean',
},
Expand Down
8 changes: 1 addition & 7 deletions packages/next/src/server/config-shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,6 @@ export interface ExperimentalConfig {
nextScriptWorkers?: boolean
scrollRestoration?: boolean
externalDir?: boolean
/**
* The App Router (app directory) enables support for layouts, Server Components, streaming, and colocated data fetching.
* @see https://nextjs.org/docs/app/api-reference/next-config-js/appDir
*/
appDir?: boolean
amp?: {
optimizer?: any
validator?: string
Expand Down Expand Up @@ -702,7 +697,7 @@ export const defaultConfig: NextConfig = {
deploymentId: undefined,
useDeploymentIdServerActions: false,
appDocumentPreloading: undefined,
clientRouterFilter: false,
clientRouterFilter: true,
clientRouterFilterRedirects: false,
fetchCacheKeyPrefix: '',
middlewarePrefetch: 'flexible',
Expand All @@ -727,7 +722,6 @@ export const defaultConfig: NextConfig = {
gzipSize: true,
craCompat: false,
esmExternals: true,
appDir: true,
// default to 50MB limit
isrMemoryCacheSize: 50 * 1024 * 1024,
incrementalCacheHandlerPath: undefined,
Expand Down
7 changes: 0 additions & 7 deletions packages/next/src/server/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -425,13 +425,6 @@ function assignDefaults(
silent
)

if (
typeof userConfig.experimental?.clientRouterFilter === 'undefined' &&
result.experimental?.appDir
) {
result.experimental.clientRouterFilter = true
}

if (
result.experimental?.outputFileTracingRoot &&
!isAbsolute(result.experimental.outputFileTracingRoot)
Expand Down
Loading