Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs #56809

Merged
merged 10 commits into from Oct 16, 2023
Merged

Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs #56809

merged 10 commits into from Oct 16, 2023

Conversation

gnoff
Copy link
Contributor

@gnoff gnoff commented Oct 13, 2023 •
edited

The latest React canary builds have a few changes that need to be adopted for compatability.

  1. the useFormState and useFormStatus hooks in react-dom and the formData opiont in react-dom/server are no longer prefixed with experimental_
  2. server content (an undocumented React feature) has been removed. Next only had trivial intenral use of this API and did not expose a coherent feature to Next users (no ability to seed context on refetches). It is still possible that some users used the React server context APIs which is why this should go into Next 14.

React upstream changes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 13, 2023
@ijjk
Copy link
Member

ijjk commented Oct 13, 2023 •
edited

Tests Passed

styfle
styfle reviewed Oct 13, 2023
View reviewed changes
packages/next/src/server/app-render/required-scripts.tsx
@@ -5,7 +5,7 @@ import ReactDOM from 'react-dom'
export function getRequiredScripts(
buildManifest: BuildManifest,
assetPrefix: string,
crossOrigin: string | undefined,
crossOrigin: undefined | '' | 'anonymous' | 'use-credentials',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we might want to change this from explicit type to some shared type that matches the caller

styfle
styfle previously approved these changes Oct 13, 2023
View reviewed changes
@socket-security
Copy link

socket-security bot commented Oct 13, 2023 •
edited

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
scheduler 0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 0.24.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013 None +0/-0 117 kB react-bot
scheduler 0.0.0-experimental-d900fadbf-20230929...0.24.0-canary-09fbee89d-20231013, 0.24.0-canary-d900fadbf-20230929...0.24.0-canary-09fbee89d-20231013 None +0/-0 117 kB react-bot
react 0.0.0-experimental-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013 None +0/-0 405 kB react-bot
react 0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013 None +0/-0 433 kB react-bot
react-dom 0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013 None +5/-0 10.4 MB react-bot
react-dom 0.0.0-experimental-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013 None +5/-10 8.58 MB react-bot

@huozhi huozhi mentioned this pull request Oct 13, 2023
Closed
@ijjk
Copy link
Member

ijjk commented Oct 13, 2023 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6.2s 6.1s N/A
nodeModulesSize 172 MB 173 MB ⚠️ +632 kB
nextStartRea..uration (ms) 536ms 537ms N/A
Client Bundles (main, webpack)
vercel/next.js canary gnoff/next.js update-react Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 50.9 kB N/A N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.3 kB 45.3 kB ✓
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
3c4a14c2-HASH.js gzip N/A 53.1 kB N/A
Overall change 45.5 kB 45.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js update-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary gnoff/next.js update-react Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.08 kB 1.08 kB ✓
Client Build Manifests
vercel/next.js canary gnoff/next.js update-react Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary gnoff/next.js update-react Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary gnoff/next.js update-react Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 152 kB 154 kB ⚠️ +2.41 kB
Overall change 152 kB 154 kB ⚠️ +2.41 kB
Middleware size
vercel/next.js canary gnoff/next.js update-react Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Diff details
Diff for page.js

Diff too large to display

Diff for 199-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Commit: 6e7be35

@gnoff gnoff requested a review from a team as a code owner October 13, 2023 20:39
@gnoff gnoff requested review from ismaelrumzan and Nutlope and removed request for a team October 13, 2023 20:39
@ijjk ijjk added area: documentation examples Issue/PR related to examples labels Oct 13, 2023
@gnoff gnoff force-pushed the update-react branch 3 times, most recently from 8092f80 to 48d63c9 Compare October 13, 2023 23:34
@gnoff gnoff changed the title Update React from d900fadbf to 09fbee89d. Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs Oct 13, 2023
@styfle styfle marked this pull request as draft October 14, 2023 15:56
@styfle
Copy link
Member

styfle commented Oct 14, 2023

I converted to a draft since the description said not to merge until 14

@gnoff
Update React from d900fadbf to 09fbee89d
a188df1 
- facebook/react#27513
- facebook/react#27514
- facebook/react#27511
- facebook/react#27508
- facebook/react#27502
- facebook/react#27474
- facebook/react#26789
- facebook/react#27500
- facebook/react#27488
- facebook/react#27458
- facebook/react#27471
- facebook/react#27470
- facebook/react#27464
- facebook/react#27456
- facebook/react#27462
- facebook/react#27461
- facebook/react#27460
- facebook/react#27459
- facebook/react#27454
- facebook/react#27457
- facebook/react#27453
- facebook/react#27401
- facebook/react#27443
- facebook/react#27445
- facebook/react#27364
- facebook/react#27440
- facebook/react#27436
@gnoff
Update tests and code to satisfy new React APIs and type changes
79484d2
@gnoff
React is removing Server Context (it was never documented) and Next n…
57e78b1 
…ever fully implemented it anyway. This removes any references to server context APIs (entirely internal) which is now required since the latest React canary no longer exposes these APIs.
@gnoff
useFormState and useFormStatus are no longer experimental APIs and ex…
22e1f03 
…ist in canary and experimental builds without the `experimental_` prefix. This commit updates our docs, examples, and tests to reflect this.
@gnoff
fix lints
83ff59d
@gnoff gnoff marked this pull request as ready for review October 16, 2023 17:42
@ztanner ztanner merged commit 0a80017 into vercel:canary Oct 16, 2023
94 of 106 checks passed
@gnoff gnoff deleted the update-react branch October 17, 2023 18:01
@leonaves
Copy link

Why are you publishing docs saying this stuff can be used when it's not in stable release??

@apostolos apostolos mentioned this pull request Oct 24, 2023
Closed
@github-actions github-actions bot added the locked label Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@styfle styfle styfle approved these changes

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@Nutlope Nutlope Awaiting requested review from Nutlope Nutlope is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gnoff @ijjk @styfle @leonaves @sebmarkbage @huozhi @ztanner