feat: drop Node.js 16 #56896
Merged
feat: drop Node.js 16 #56896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node.js 16 has reached end-of-life in September.
ijjk
added
create-next-app
Merged
Tests Passed |
balazsorban44
commented
Oct 16, 2023
| @@ -57,10 +57,6 @@ Next.js allows you to use the latest JavaScript features out of the box. In addi | |||
| - [Class Fields](https://github.com/tc39/proposal-class-fields) and [Static Properties](https://github.com/tc39/proposal-static-class-features) (part of stage 3 proposal) | |||
| - and more! | |||
|
|
|||
| ### Server-Side Polyfills | |||
There was a problem hiding this comment.
fetch is not polyfilled anymore (not needed), but I think this section could be its own page anyway.
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
balazsorban44
commented
Oct 16, 2023
balazsorban44
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
balazsorban44
requested review from
manovotny and
timeyoutakeit
and removed request for
a team
styfle
reviewed
Oct 16, 2023
ijjk
approved these changes
Oct 16, 2023
balazsorban44
added a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit 1ff7f07.
3 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
### What? Note: This is not a breaking change, just removing some unused code. ### Why? Since #56896 we don't need this, as Node.js 18+ has `fetch` exposed by default. ### How? Depends on #56896, #56909 We already didn't load `fetch` if `globalThis` had it (ie. Node.js 18+ environments), and since we are dropping support for Node.js 16, these code paths should have no effect on runtime behavior.
|
@hanayashiki yes? Why am i being tagged here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
BREAKING CHANGE: Bump the minimum required Node.js version.
Why?
Node.js 16 has reached end-of-life in September.
Bumped to
18.18.2since it contained some security-related patches: https://nodejs.org/en/blog/vulnerability/october-2023-security-releasesHow?
Bumped
engineswhere needed, upgraded the workflows.This will allow us to remove quite a few polyfills, I'll open separate PRs for those.