chore: upgrade jest
#56909
Merged
chore: upgrade jest
#56909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
Tests Passed |
Merged
wyattjoh
previously approved these changes
Oct 16, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
balazsorban44
commented
Oct 17, 2023
| @@ -1062,7 +1062,7 @@ export async function getRedboxComponentStack( | |||
| */ | |||
| export const describeVariants = { | |||
| each(variants: TestVariants[]) { | |||
| return (name: string, fn: (...args: TestVariants[]) => any) => { | |||
| return (name: string, fn: (variants: TestVariants) => any) => { | |||
There was a problem hiding this comment.
Needed to tweak TS here
balazsorban44
commented
Oct 17, 2023
test/jest.d.ts
Outdated
There was a problem hiding this comment.
Inlined in tsconfig.json. See: https://github.com/vercel/next.js/pull/56909/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R13
balazsorban44
commented
Oct 17, 2023
Comment on lines
-20
to
-22
| globals: { | ||
| AbortSignal: global.AbortSignal, | ||
| }, |
There was a problem hiding this comment.
We can get rid of this thanks to https://jestjs.io/blog/2022/04/25/jest-28#all-nodejs-globals
wyattjoh
previously approved these changes
Oct 17, 2023
wyattjoh
approved these changes
Oct 19, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
### What? Note: This is not a breaking change, just removing some unused code. ### Why? Since #56896 we don't need this, as Node.js 18+ has `fetch` exposed by default. ### How? Depends on #56896, #56909 We already didn't load `fetch` if `globalThis` had it (ie. Node.js 18+ environments), and since we are dropping support for Node.js 16, these code paths should have no effect on runtime behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade jest to its latest version
Why?
#56899 fails because historically Jest stripped the globals in Node.js, but 28+ isn't doing that anymore. If we upgrade, we don't have to keep track of Node.js globals and when they are added. This will be useful in removing even more polyfills for things that are natively shipped in Node.js now.
How?
Jest 29 introduced a change to the snapshot format: https://jestjs.io/blog/2022/08/25/jest-29
First, I tried setting the old compat option to not require updating snapshots, but some tests were still failing: https://dev.azure.com/nextjs/next.js/_build/results?buildId=70633&view=logs&j=8af7cf9c-43a1-584d-6f5c-57bad8880974&t=7ae70e63-3625-50f4-6764-5b3e72b4bd7a&l=273 So going through the pain now instead.