Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested unstable_cache revalidating #57316

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 24, 2023

This ensures when we call revalidateTag and there are nested unstable_cache entries we properly revalidate.

@ijjk
Copy link
Member Author

ijjk commented Oct 24, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
buildDuration 10.4s 10.3s N/A
buildDurationCached 6.3s 6.2s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +1.02 kB
nextStartRea..uration (ms) 398ms 401ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
199-HASH.js gzip 29.8 kB 29.8 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 250 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
index.html gzip 529 B 529 B
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 524 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 138 kB 138 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js fix/nested-unstable-cache Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 24.9 kB 24.9 kB
Commit: 555b201

@kodiakhq kodiakhq bot merged commit 8b01e25 into vercel:canary Oct 24, 2023
52 of 57 checks passed
@ijjk ijjk deleted the fix/nested-unstable-cache branch October 24, 2023 05:01
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants