Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix turbopack invalidations #57362

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Oct 24, 2023

Why?

fixes all the app-dir/hooks tests

Closes WEB-1845

@ijjk
Copy link
Member

ijjk commented Oct 24, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
buildDuration 10.7s 10.6s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 416ms 425ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 250 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
index.html gzip 527 B 529 B N/A
link.html gzip 540 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/fix-turbopack-invalidations Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 82d8567

@ijjk
Copy link
Member

ijjk commented Oct 24, 2023

Tests Passed

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/fix-turbopack-invalidations branch from b353286 to 01b2b8d Compare October 26, 2023 02:24
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/fix-turbopack-invalidations branch from 01b2b8d to 0325b3a Compare October 26, 2023 03:06
@ForsakenHarmony ForsakenHarmony merged commit c80fb27 into canary Oct 26, 2023
52 of 57 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/fix-turbopack-invalidations branch October 26, 2023 05:04
ForsakenHarmony added a commit that referenced this pull request Oct 26, 2023
sokra pushed a commit that referenced this pull request Oct 26, 2023
### Why?

breaks hmr and causes some duplicate react instances (it was also
supposed to fix some of those, seems neither version is correct)

Closes WEB-1882
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants