Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for disabling output file tracing #57467

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 26, 2023

image

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
buildDuration 10.5s 10.5s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +2.06 kB
nextStartRea..uration (ms) 421ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 524 B 524 B
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js deprecate-output-file-tracing Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 27.5 kB 27.5 kB
Commit: 8e1988f

@huozhi huozhi marked this pull request as ready for review October 26, 2023 03:42
@vercel-spaces
Copy link

vercel-spaces bot commented Oct 26, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @styfle:

packages/next/src/server/config.ts

shuding
shuding previously approved these changes Oct 26, 2023
ijjk
ijjk previously approved these changes Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Failing test suites

Commit: 8e1988f

pnpm test-dev test/e2e/app-dir/app-css/index.test.ts

  • app dir - css > HMR > should support HMR with sass/scss
Expand output

● app dir - css › HMR › should support HMR with sass/scss

TIMED OUT: rgb(255, 0, 0)

rgb(222, 184, 135)

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (e2e/app-dir/app-css/index.test.ts:770:13)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/not-found/basic/index.test.ts

  • app dir - not-found - basic > with runtime = edge > should render the 404 page when the file is removed, and restore the page when re-added
Expand output

● app dir - not-found - basic › with runtime = edge › should render the 404 page when the file is removed, and restore the page when re-added

TIMED OUT: Root Not Found

My page

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (e2e/app-dir/not-found/basic/index.test.ts:106:11)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi dismissed stale reviews from ijjk and shuding via c88f3a0 October 26, 2023 05:10
@huozhi huozhi requested review from ijjk and shuding October 26, 2023 05:10
@sokra sokra merged commit b3e5392 into canary Oct 26, 2023
49 of 57 checks passed
@sokra sokra deleted the deprecate-output-file-tracing branch October 26, 2023 06:51
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants